Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wpf conversion part three #1371

Closed

Conversation

Lucasharskamp
Copy link
Collaborator

PropertyGrid control added for WPF to replace the original in Windows.Forms
FileAssocation data fixed
Localized several texts from MultiButtonMessageBoxWpf implementation
Localized several new texts only available in English
Replaced InstallPluginWindow with xaml
Replaced last existing implementations of MultiButtonMessageBox with WPF implementation
Removed unused UserControl

@vchelaru
Copy link
Owner

vchelaru commented Mar 1, 2024

I believe this is the PR to keep around but I'm not sure. Can you see which to keep?

Also I have thought about it and I think it's best if we do not support localization going forward. I cannot maintain it myself, and it adds an extra layer every time I work in UI that makes things more difficult to maintain. Could you undo the localization changes if there are any in the PR that is still around?

@vchelaru
Copy link
Owner

vchelaru commented Jun 4, 2024

This PR has become stale - it needs to be merged with the latest and thoroughly tested. I'm afraid that merging this now would introduce lots of problems. Also, it brings in too many changes. We probably need the initial changes from WpfConversionPartThree merged first and tested thoroughly before additional changes are added on top.

I'm closing this for now, but it can be re-opened if the testing mentioned above is satisfied.

@vchelaru vchelaru closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants